Cast discriminator when no title present #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorbash
reviewed
Nov 17, 2023
albertored
force-pushed
the
fix-discriminator
branch
from
702c703 to
b6bf05d
Compare
hou8
pushed a commit
to hou8/open_api_spex
that referenced
this pull request
Apr 18, 2024
Co-authored-by: Alberto Sartori <alberto.sartori@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When elements of a discriminator does not have a
titleproperty the cast fails. Themappingcan indeed contain references so we can fallback to use them to retrieve the discriminator schema fromctx.schemas.A part for variables renaming the main change is this