Skip to content

Conversation

@Zapiano
Copy link
Member

@Zapiano Zapiano commented Nov 13, 2024

Adds the ability to run many RME repetitions in batches. Note that the rnd_seed, that can be set by the user, is used to generate a vector of rnd_seeds where each one is used for running a distinct batch.

@Zapiano Zapiano added the enhancement New feature or request label Nov 13, 2024
@Zapiano Zapiano self-assigned this Nov 13, 2024
@eco-ben
Copy link

eco-ben commented Nov 18, 2024

I think this looks good to me. I can add the function to remove the duplicate counterfactual runs before saving in another branch when this is merged

@Zapiano
Copy link
Member Author

Zapiano commented Nov 18, 2024

I think this looks good to me. I can add the function to remove the duplicate counterfactual runs before saving in another branch when this is merged

You can create a branch from this one and create you PR already even before this one is merged, if you prefer.

@eco-ben
Copy link

eco-ben commented Nov 18, 2024

When I try to use the latest code with this PR I get this error adding the package. Is it a fault on my end in packages?
image

@ConnectedSystems
Copy link
Collaborator

When I try to use the latest code with this PR I get this error adding the package. Is it a fault on my end in packages? image

Minor point: dev . from within the sandbox is saying to install the sandbox as a dev'ed package - which doesn't make sense...

Unless you're not in the sandbox directory at all?

But the error seems to be pointing to ReefModEngine.jl requiring Julia v1.11 but you seem to be running Julia v1.10.4

Copy link
Collaborator

@ConnectedSystems ConnectedSystems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for consideration. Happy to be convinced otherwise.

Zapiano and others added 7 commits June 4, 2025 16:34
Co-authored-by: Takuya Iwanaga <takuyai@gmail.com>
Add function to load result stores from directories, add function to remove duplicate reps from result store if the resultstore is counterfactual only. Add function to concatenate resultstores when scenarios have been run and saved separately.
@DanTanAtAims DanTanAtAims merged commit 4ad4447 into main Jun 5, 2025
1 check passed
@DanTanAtAims DanTanAtAims deleted the add-run-reps branch June 5, 2025 01:42
@ConnectedSystems ConnectedSystems mentioned this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants