rename cubes for ADRIA compatability #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ResultStore.jl
Outdated
Comment on lines
61
to
62
| # Relative Coral cover [% of total reef area] | ||
| relative_cover = DataCube( |
There was a problem hiding this comment.
Hey Dan, are we sure this is % relative to total reef area?
There was a problem hiding this comment.
In the RME data codes it appears that it is, though perhaps the comment should specify [% of reef area] as total might imply the entire study area. The variable name used to retrieve the data from the API is 'coral_pct'
There was a problem hiding this comment.
Hmmm...
There are conflicting definitions of what "total" refers to. Let me ask.
There was a problem hiding this comment.
I've updated the names to be total_cover and total_taxa_cover.
There was a problem hiding this comment.
This is fine with me, but noting it requires changes in ADRIA for the naming convention to be fully supported.
ConnectedSystems
approved these changes
Apr 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the name of data cubes in the YAXArray dataset to align with ADRIA names. Changes the names
cover->total_coverspecies->total_taxa_coverThe variable names prior to this pull request already deviates from ReefMod's naming.