Result store update

[DanTanAtAims]

Update result store to use YAXArrays and NetCDF.

After each counterfactual and intervention run call.

append_all_results(result_store::ResultStore, start_year::Int, end_year::Int, reps::Int)

This will add the results to the YAXArray dataset and add rows to the scenario DataFrame reflecting scenario intervention factors.

├─RME_outcomes_yyyy-mm-dd-HH-MM-SS
│       results.nc
│       scenarios.csv

[ConnectedSystems]

Hey @DanTanAtAims what's the difference between the two below?

@getRME ivOutplantCountPerM2("iv_name"::Cstring)::Cdouble

# and

@RME ivOutplantCountPerM2("iv_name"::Cstring)::Cdouble

[DanTanAtAims]

The second will error out when there was no error. In the RME macro

macro RME(func)
    local m = esc(Meta.parse("@ccall RME.$(func)"))
    return quote
        local err = $m

---->   if !(typeof(err) <: Cstring) && err != 0 && !(typeof(err) <: Cvoid) # <--- this condition prevents function calls that return numbers to fail.
            local err_msg = @ccall RME.lastError()::Cstring
            throw(ArgumentError("Call to RME failed with message: $(unsafe_string(err_msg))"))
        end
        ...
    end
end

The conditions of the if statement are evaluated as follows for getters that return numeric, non-error values

!(Cdouble <: Cstring) (true)
err != 0 (true) # Importantly no error has occurred. 
!(typeof(err) <: Cvoid) (true)

So we enter the error if block. We should only use the new macro @getRME when we have no choice as we lose the safety of the error checking in the original macro.

[ConnectedSystems]

Yep, obvious now, sorry.

[ConnectedSystems]

Very last comment to address Dan, thank you.

[ConnectedSystems]

These examples need to be updated

[ConnectedSystems]

One more - update example variable as count is also a function.

Suggested change

	count::Float64 = @getRME ivOutplantCountPerM2("iv_name"::Cstring)::Cdouble
	count_per_m2::Float64 = @getRME ivOutplantCountPerM2("iv_name"::Cstring)::Cdouble

[ConnectedSystems]

Thanks @DanTanAtAims