Skip to content

Conversation

@alexsin368
Copy link
Collaborator

Adding instructions to give users the option to just pull docker images of microservices from Docker Hub which are currently available. Clean up documentation for smoother execution.

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkbhanda
Copy link
Collaborator

mkbhanda commented Sep 26, 2024

@alexsin368 you need signed-off in your commit.
https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md

Signed-off-by: asin <alex.sin@intel.com>
Signed-off-by: asin <alex.sin@intel.com>
Signed-off-by: asin <alex.sin@intel.com>
Signed-off-by: asin <alex.sin@intel.com>
Signed-off-by: asin <alex.sin@intel.com>
@alexsin368
Copy link
Collaborator Author

Signed off previous commits including the new commit. Addressed all comments.

Signed-off-by: asin <alex.sin@intel.com>
@alexsin368
Copy link
Collaborator Author

Hi, if everything looks good, can someone else approve and merge the changes? Thanks.

@chickenrae chickenrae merged commit 77df4f7 into opea-project:main Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants