-
Notifications
You must be signed in to change notification settings - Fork 87
github.io documentation for aipc #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: devpramod <pramod.pai@intel.com>
dbkinder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix missing close fence for tab-set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the instructions leaner by using the images from docker hub.
dbkinder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please delete the existing AIPC.rst in this PR to get rid of the previous placeholder doc.
Signed-off-by: devpramod <pramod.pai@intel.com>
Signed-off-by: devpramod <pramod.pai@intel.com>
dbkinder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
close enough. thanks
|
@devpramod would you please "resolve" the conversations addressed. What is the consensus -- with close enough, skip using prebuilt images? |
Signed-off-by: devpramod <pramod.pai@intel.com>
Signed-off-by: devpramod <pramod.pai@intel.com>
|
@mkbhanda Resolved the addressed conversations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm back to "close enough" for now, and we'll see what happens with the next updates @preethivenkatesh and @tomlenth have in mind. We do need to "resolve" the 35 suggestions not being made in this PR so we can merge it...
|
Approving this with the expectation that we address the need for a new template that leverages pre-built images where available |
|
@devpramod would you kindly "resolve" issues .. just click it, you have followed the template and thus this PR is eligible for merge. |
No description provided.