Skip to content

Conversation

@devpramod
Copy link
Contributor

No description provided.

Signed-off-by: devpramod <pramod.pai@intel.com>
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix missing close fence for tab-set

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the instructions leaner by using the images from docker hub.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please delete the existing AIPC.rst in this PR to get rid of the previous placeholder doc.

Signed-off-by: devpramod <pramod.pai@intel.com>
Signed-off-by: devpramod <pramod.pai@intel.com>
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close enough. thanks

@mkbhanda
Copy link
Collaborator

@devpramod would you please "resolve" the conversations addressed. What is the consensus -- with close enough, skip using prebuilt images?

Signed-off-by: devpramod <pramod.pai@intel.com>
Signed-off-by: devpramod <pramod.pai@intel.com>
@devpramod
Copy link
Contributor Author

@mkbhanda Resolved the addressed conversations.
Yes, looks like for this iteration we'll build the image, same as in the Xeon template.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm back to "close enough" for now, and we'll see what happens with the next updates @preethivenkatesh and @tomlenth have in mind. We do need to "resolve" the 35 suggestions not being made in this PR so we can merge it...

@mkbhanda
Copy link
Collaborator

Approving this with the expectation that we address the need for a new template that leverages pre-built images where available

@mkbhanda
Copy link
Collaborator

@devpramod would you kindly "resolve" issues .. just click it, you have followed the template and thus this PR is eligible for merge.

@dbkinder dbkinder merged commit 16c211b into opea-project:main Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants