kubeai/readme: fix mistake in nri policy config#1115
Merged
poussa merged 1 commit intoopea-project:mainfrom Jun 12, 2025
Merged
kubeai/readme: fix mistake in nri policy config#1115poussa merged 1 commit intoopea-project:mainfrom
poussa merged 1 commit intoopea-project:mainfrom
Conversation
mkbhanda
reviewed
Jun 12, 2025
Collaborator
mkbhanda
left a comment
mkbhanda
left a comment
There was a problem hiding this comment.
minor edits and a question
| ## Overview | ||
|
|
||
| [NRI plugins][nri-plugins] provide a way to | ||
| optimize the resource placement of applications in a Kubernetes cluster. They |
Collaborator
There was a problem hiding this comment.
Suggested change
| optimize the resource placement of applications in a Kubernetes cluster. They | |
| optimize the resources allocated to an application in a Kubernetes cluster. They |
Collaborator
Author
There was a problem hiding this comment.
Thx. See #1119. I used wording "node-level resource assignment" there
| ## Installation of Balloons Policy Plugin | ||
|
|
||
| > **NOTE:** To avoid disturbing already running workloads it is recommended to | ||
| > install the NRI plugin to an empty node (do it right after node bootstrap, or |
Collaborator
There was a problem hiding this comment.
Suggested change
| > install the NRI plugin to an empty node (do it right after node bootstrap, or | |
| > install the NRI plugin on an empty node, that is, before launching workloads on the same (do it right after node bootstrap, or |
|
|
||
| > **NOTE:** To avoid disturbing already running workloads it is recommended to | ||
| > install the NRI plugin to an empty node (do it right after node bootstrap, or | ||
| > drain the node before installation). |
Collaborator
There was a problem hiding this comment.
Suggested change
| > drain the node before installation). | |
| > drain the node of work before installation). |
Collaborator
Author
There was a problem hiding this comment.
"draining a node" (kubectl drain <node>) is a well-established term in Kubernetes so I didn't change this
|
|
||
| > **NOTE**: With containerd version earlier than v2.0 you need to enable | ||
| > the NRI support in the containerd configuration file. Instead of manual | ||
| > configuration you can provide `--set nri.runtime.patchConfig=true` to the Helm |
Collaborator
There was a problem hiding this comment.
Suggested change
| > configuration you can provide `--set nri.runtime.patchConfig=true` to the Helm | |
| > configuring/editing the file, you can pass in `--set nri.runtime.patchConfig=true` to the Helm |
Collaborator
Author
There was a problem hiding this comment.
Thx. See #1119. I used slightly different wording
| ## Configuration of Balloons Policy Plugin | ||
|
|
||
| The aim of the balloons policy configuration is to isolate the model (inference | ||
| engine) containers to minimize the impact of containers on each other. |
Collaborator
There was a problem hiding this comment.
Suggested change
| engine) containers to minimize the impact of containers on each other. | |
| engine containers, to minimize noisy neighbor effects, interfering with each other. |
Collaborator
Author
There was a problem hiding this comment.
Thx. See #1119. I used slightly different wording
|
|
||
| # Observability | ||
|
|
||
| With [Prometheus](../helm-charts/monitoring.md) running, install script can enable monitoring of the vLLM inference engine instances. |
Collaborator
There was a problem hiding this comment.
which install script? Are you asking the user to install a script for observability?
Collaborator
Author
There was a problem hiding this comment.
I think this refers to kubeai/install.sh
Fix a mistake in the balloons policy config snippet. We want to match pod labels not container labels. Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
marquiz
force-pushed
the
devel/kubeai-nri
branch
from
3a11dec to
2867399
Compare
Collaborator
Author
poussa
approved these changes
Jun 12, 2025
eero-t
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a mistake in the balloons policy config snippet. We want to match pod labels not container labels.