Add monitoring for VisualQnA deployed by Docker compose.#2319
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds monitoring capabilities to the VisualQnA application by integrating Prometheus and Grafana monitoring stack through Docker Compose. The changes enable comprehensive metrics collection and visualization for both Xeon CPU and Gaudi HPU deployments.
- Integration of monitoring stack (Prometheus, Grafana, Node Exporter) via compose.monitoring.yaml files
- Addition of configuration files for Grafana dashboards and data sources
- Update of test scripts to include monitoring containers in start/stop operations
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| VisualQnA/tests/test_compose_tgi_on_xeon.sh | Updated to include monitoring compose file in Docker operations |
| VisualQnA/tests/test_compose_tgi_on_gaudi.sh | Updated to include monitoring compose file in Docker operations |
| VisualQnA/tests/test_compose_on_xeon.sh | Updated to include monitoring compose file and standardized stop command |
| VisualQnA/tests/test_compose_on_gaudi.sh | Updated to include monitoring compose file and standardized stop command |
| VisualQnA/docker_compose/intel/hpu/gaudi/set_env.sh | Added Grafana dashboard download and expanded no_proxy configuration |
| VisualQnA/docker_compose/intel/hpu/gaudi/prometheus.yaml | New Prometheus configuration for Gaudi deployment |
| VisualQnA/docker_compose/intel/hpu/gaudi/grafana/provisioning/datasources/datasource.yml | Grafana data source configuration |
| VisualQnA/docker_compose/intel/hpu/gaudi/grafana/provisioning/dashboards/local.yaml | Grafana dashboard provisioning configuration |
| VisualQnA/docker_compose/intel/hpu/gaudi/grafana/dashboards/download_opea_dashboard.sh | Script to download pre-configured Grafana dashboards |
| VisualQnA/docker_compose/intel/hpu/gaudi/compose.monitoring.yaml | Docker Compose configuration for monitoring stack on Gaudi |
| VisualQnA/docker_compose/intel/cpu/xeon/set_env.sh | Added Grafana dashboard download and expanded no_proxy configuration |
| VisualQnA/docker_compose/intel/cpu/xeon/prometheus.yaml | New Prometheus configuration for Xeon deployment |
| VisualQnA/docker_compose/intel/cpu/xeon/grafana/provisioning/datasources/datasource.yml | Grafana data source configuration |
| VisualQnA/docker_compose/intel/cpu/xeon/grafana/provisioning/dashboards/local.yaml | Grafana dashboard provisioning configuration |
| VisualQnA/docker_compose/intel/cpu/xeon/grafana/dashboards/download_opea_dashboard.sh | Script to download pre-configured Grafana dashboards |
| VisualQnA/docker_compose/intel/cpu/xeon/compose.monitoring.yaml | Docker Compose configuration for monitoring stack on Xeon |
Comments suppressed due to low confidence (1)
VisualQnA/docker_compose/intel/cpu/xeon/grafana/dashboards/download_opea_dashboard.sh:1
- The wget commands lack error handling. If any dashboard download fails, the script continues silently. Consider adding error checking or using 'wget -q' with exit code validation to ensure all required dashboards are downloaded successfully.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
VisualQnA/docker_compose/intel/hpu/gaudi/grafana/dashboards/download_opea_dashboard.sh
Show resolved
Hide resolved
…wnload_opea_dashboard.sh Signed-off-by: ZePan110 <ze.pan@intel.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
yao531441
approved these changes
Nov 3, 2025
joshuayao
approved these changes
Nov 3, 2025
yao531441
pushed a commit
that referenced
this pull request
Nov 4, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Yao, Qing <qing.yao@intel.com>
cogniware-devops
pushed a commit
to Cogniware-Inc/GenAIExamples
that referenced
this pull request
Dec 19, 2025
…t#2319) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
cogniware-devops
pushed a commit
to Cogniware-Inc/GenAIExamples
that referenced
this pull request
Dec 19, 2025
…t#2319) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
cogniware-devops
pushed a commit
to Cogniware-Inc/GenAIExamples
that referenced
this pull request
Dec 19, 2025
…t#2319) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add monitoring for VisualQnA deployed by Docker compose
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.
