Skip to content

Conversation

zhihangdeng
Copy link
Collaborator

Description

This PR introduces support for the openEuler OS in the one-click deployment feature. The changes include compatibility adjustments and testing for deployment scripts and configurations.

Issues

#2236

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@Copilot Copilot AI review requested due to automatic review settings September 11, 2025 10:38
Copy link

github-actions bot commented Sep 11, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the openEuler operating system to the one-click deployment feature. The changes introduce OS-specific configuration options and Docker Compose paths while maintaining backward compatibility with existing Debian-based deployments.

  • Adds OS selection prompts to deployment workflows with support for both Debian and openEuler
  • Introduces OS-specific Docker Compose file paths and service configurations
  • Updates CI workflows to test openEuler compatibility alongside existing Debian support

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
one_click_deploy/core/deployer.py Adds OS parameter handling and prompts for interactive setup flows
one_click_deploy/core/config.py Restructures device support to be OS-specific and adds openEuler configurations
one_click_deploy/common/update_images.sh Adds OS parameter support and openEuler-specific service handling
one_click_deploy/common/utils.sh Increases section header width for better formatting
.github/workflows/pr-one-click.yml Updates CI matrix to include openEuler OS testing
.github/workflows/one-click-inputs.json Adds OS parameter to input sequences
.github/workflows/one-click-inputs-nobuild.json Adds OS parameter to no-build input sequences
.github/workflows/_run-one-click.yml Adds OS input parameter and removes deprecated source list cleanup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

export TAG

local service_list=$(get_service_list "$example_name" "$device_name")
local service_list=$(get_service_list "$example_name" "$device_name" "$os_name" )
Copy link
Preview

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space before the closing parenthesis should be removed.

Suggested change
local service_list=$(get_service_list "$example_name" "$device_name" "$os_name" )
local service_list=$(get_service_list "$example_name" "$device_name" "$os_name")

Copilot uses AI. Check for mistakes.

Signed-off-by: zhihang <zhihangdeng@link.cuhk.edu.cn>
@zhihangdeng
Copy link
Collaborator Author

Hi, @chensuyue and @ZePan110, it seems that the docker test works well and the only thing left to do is to complete the k8s test.

@zhihangdeng
Copy link
Collaborator Author

zhihangdeng commented Sep 11, 2025

We need to wait for

Hi, @chensuyue and @ZePan110, it seems that the docker test works well and the only thing left to do is to complete the k8s test.

Before that, we need to complete #2263 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant