Add validated matrix for AgentQnA #2080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chensuyue
requested review from
ashahba,
lkk12014402,
minmin-intel and
XinyuYe-Intel
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a validated configuration matrix for AgentQnA and refactors the test script for container management.
- Refactored container stop functions in the test script to a single stop_docker function.
- Updated README.md with a new validated configurations table.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AgentQnA/tests/test_compose_on_gaudi.sh | Refactored multiple stop container functions into a unified stop_docker function. |
| AgentQnA/README.md | Added a validated configurations table to document supported deployment options. |
Comments suppressed due to low confidence (1)
AgentQnA/tests/test_compose_on_gaudi.sh:23
- The variable RETRIEVAL_TOOL_PATH is used but no longer defined in this function. Consider reintroducing its declaration or updating the path to reference a defined variable.
cd $RETRIEVAL_TOOL_PATH/docker_compose/intel/cpu/xeon/
Signed-off-by: chensuyue <suyue.chen@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: chensuyue <suyue.chen@intel.com>
ZePan110
approved these changes
Jun 18, 2025
letonghan
approved these changes
Jun 18, 2025
lvliang-intel
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.