Skip to content

[CICD enhance] run CI with latest base image, group logs in GHA outputs. #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025

Conversation

chensuyue
Copy link
Collaborator

@chensuyue chensuyue commented Jun 16, 2025

Description

  1. Translation run CI with latest base image, group logs in GHA outputs.
  2. Text2Image group logs in GHA outputs.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: chensuyue <suyue.chen@intel.com>
@Copilot Copilot AI review requested due to automatic review settings June 16, 2025 08:45
Copy link

github-actions bot commented Jun 16, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates CI scripts to use the latest base image dynamically and groups key steps in GitHub Actions logs.

  • Emit the GenAIComps commit hash and build a configurable comps-base image.
  • Wrap CI phases (stop, build, start, validate, prune) in ::group::/::endgroup:: markers.
  • Add IMAGE_REPO and BASE_TAG build args in build.yaml and make FROM dynamic in the Dockerfile.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Translation/tests/test_compose_vllm_on_rocm.sh Added commit echo, dynamic build, log grouping, stderr redirect
Translation/tests/test_compose_on_xeon.sh Added dynamic build guard, grouping, stderr redirect
Translation/tests/test_compose_on_rocm.sh Added dynamic build guard, grouping, stderr redirect
Translation/tests/test_compose_on_gaudi.sh Restored validate_frontend, added grouping, stderr redirect
Translation/docker_image_build/build.yaml Exposed IMAGE_REPO and BASE_TAG as build arguments
Translation/Dockerfile Made FROM use configurable IMAGE_REPO and BASE_TAG
Text2Image/tests/test_compose_on_xeon.sh Added grouping around CI steps
Text2Image/tests/test_compose_on_gaudi.sh Added grouping around CI steps
Comments suppressed due to low confidence (3)

Translation/docker_image_build/build.yaml:8

  • [nitpick] Consider adding IMAGE_REPO and BASE_TAG build arguments to other service definitions (e.g., translation-ui, llm-textgen) so they can also pull from the intended base image repository.
IMAGE_REPO: ${REGISTRY:-opea}

Translation/tests/test_compose_vllm_on_rocm.sh:186

  • [nitpick] It may be clearer to wrap docker system prune -f in its own ::group::/::endgroup:: block to keep its logs isolated and improve readability.
docker system prune -f

Translation/tests/test_compose_vllm_on_rocm.sh:24

  • [nitpick] The sleep 1s after the build may be too short for all processes to settle—consider aligning it with the existing sleep 3s used after docker images to ensure stability.
popd && sleep 1s

Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
@chensuyue chensuyue merged commit 6f7daf8 into main Jun 17, 2025
25 checks passed
@chensuyue chensuyue deleted the suyue/opt2 branch June 17, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants