Skip to content

[CICD enhance] VideoQnA run CI with latest base image, group logs in GHA outputs. #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

chensuyue
Copy link
Collaborator

@chensuyue chensuyue commented Jun 16, 2025

Description

  • Fix image build service name typo.
  • Integrate set_env.sh into CI test scripts.
  • Enable latest base image test for CI.
  • Group log lines in GHA outputs for better readable logs.

Issues

https://github.com/opea-project/GenAIExamples/actions/runs/15613666318/job/44023040118

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: chensuyue <suyue.chen@intel.com>
@Copilot Copilot AI review requested due to automatic review settings June 16, 2025 05:51
@chensuyue chensuyue requested a review from BaoHuiling as a code owner June 16, 2025 05:51
Copy link

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the CICD pipeline for VideoQnA by correcting a build service naming typo, integrating an environment setup script into the CI tests, and grouping log outputs in GitHub Actions for improved readability.

  • Fixed image build service name typo in the Dockerfile and build configuration.
  • Integrated set_env.sh into CI test scripts, removing duplicated environment setup logic.
  • Added group markers for log outputs in various CI steps.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
VideoQnA/tests/test_compose_on_xeon.sh Removed local environment setup function and integrated set_env.sh; added CI log grouping.
VideoQnA/docker_image_build/build.yaml Added new build arguments (IMAGE_REPO and BASE_TAG) and updated service naming for embedding.
VideoQnA/docker_compose/intel/cpu/xeon/set_env.sh Removed duplicate HF_TOKEN export to avoid redundancy.
VideoQnA/Dockerfile Parameterized the FROM clause with IMAGE_REPO and BASE_TAG for flexibility.
Comments suppressed due to low confidence (4)

VideoQnA/docker_image_build/build.yaml:8

  • Document the new build arguments IMAGE_REPO and BASE_TAG in the CI or developer documentation to ensure clarity on their usage and defaults across Dockerfiles.
IMAGE_REPO: ${REGISTRY:-opea}

VideoQnA/docker_image_build/build.yaml:28

  • Verify that the updated service name 'embedding-multimodal-clip' is consistent with its usage in other configuration files and documentation, to avoid confusion.
embedding-multimodal-clip:

VideoQnA/tests/test_compose_on_xeon.sh:44

  • Ensure that sourcing set_env.sh covers all necessary environment variable initializations previously handled by the local setup_env function, and that the script is present and executable in the expected location.
source ./set_env.sh

VideoQnA/Dockerfile:6

  • Confirm that the use of the IMAGE_REPO build argument in the FROM clause aligns with your project's repository naming conventions and that similar changes are applied consistently across all Dockerfiles.
FROM $IMAGE_REPO/comps-base:$BASE_TAG

@chensuyue chensuyue merged commit 8d75f0a into main Jun 17, 2025
19 checks passed
@chensuyue chensuyue deleted the suyue/opt1 branch June 17, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants