Refine Configurable Ports in DocSum #1978
Open
+65
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: letonghan <letong.han@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull Request Overview
This PR refines the configurable ports in DocSum’s Docker Compose files and updates related documentation.
- Updated port mappings in both Gaudi and Xeon configurations (HPU and CPU) to use environment variables.
- Revised README notes to highlight the need to update local port configurations when conflicts occur.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| DocSum/docker_compose/intel/hpu/gaudi/compose_tgi.yaml | Updates port mapping and adds LLM_SERVICE_PORT and ASR_SERVICE_PORT environment variables. |
| DocSum/docker_compose/intel/hpu/gaudi/compose.yaml | Updates LLM endpoint and port mapping with new configurable variables. |
| DocSum/docker_compose/intel/hpu/gaudi/README.md | Improves documentation on port configuration for local development. |
| DocSum/docker_compose/intel/cpu/xeon/compose_tgi.yaml | Updates port mapping and adds environment variables for LLM and ASR services. |
| DocSum/docker_compose/intel/cpu/xeon/compose.yaml | Updates LLM endpoint and port mapping with new configurable variables. |
| DocSum/docker_compose/intel/cpu/xeon/README.md | Enhances documentation with new instructions for handling local port conflicts. |
Files not reviewed (1)
- DocSum/docker_compose/intel/set_env.sh: Language not supported
Signed-off-by: letonghan <letong.han@intel.com>
…mples into docsum_refine
Signed-off-by: letonghan <letong.han@intel.com>
…mples into docsum_refine
|
Test failed to return code 000 (instead of 200). Rebased to latest |
…into docsum_refine
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: letonghan <letong.han@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make all ports configurable in docsum.
Refine READMEs.
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
Local tested