Skip to content

Conversation

@opatry
Copy link
Owner

@opatry opatry commented Oct 11, 2024

Description

When updated to Ktor3, the Coil3 network module was kept relying on Ktor2, which led to NoClassDefFoundError error.

Checklist

  • I have read the CONTRIBUTING guide
  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing

@github-actions
Copy link
Contributor

©️ Stale credits for :tasks-app-desktop

diff --git a/tasks-app-desktop/src/main/resources/licenses_desktop.json b/tasks-app-desktop/src/main/resources/licenses_desktop.json
index 274cae3..3e9466b 100644
--- a/tasks-app-desktop/src/main/resources/licenses_desktop.json
+++ b/tasks-app-desktop/src/main/resources/licenses_desktop.json
@@ -325,7 +325,7 @@
]
},
{
- "uniqueId": "io.coil-kt.coil3:coil-network-ktor2-jvm",
+ "uniqueId": "io.coil-kt.coil3:coil-network-ktor3-jvm",
"developers": [
{
"name": "Coil Contributors"
@@ -333,7 +333,7 @@
],
"artifactVersion": "3.0.0-alpha10",
"description": "An image loading library for Android and Compose Multiplatform.",
- "name": "coil-network-ktor2",
+ "name": "coil-network-ktor3",
"licenses": [
"Apache-2.0"
]

Run ./gradlew :tasks-app-desktop:exportLibraryDefinitions -PaboutLibraries.exportPath=src/main/resources and commit resulting diff to fix the issue.

@github-actions
Copy link
Contributor

©️ Stale credits for :tasks-app-android

diff --git a/tasks-app-android/src/main/assets/licenses_android.json b/tasks-app-android/src/main/assets/licenses_android.json
index f5fb798..1559ebc 100644
--- a/tasks-app-android/src/main/assets/licenses_android.json
+++ b/tasks-app-android/src/main/assets/licenses_android.json
@@ -1877,7 +1877,7 @@
]
},
{
- "uniqueId": "io.coil-kt.coil3:coil-network-ktor2-android",
+ "uniqueId": "io.coil-kt.coil3:coil-network-ktor3-android",
"developers": [
{
"name": "Coil Contributors"
@@ -1885,7 +1885,7 @@
],
"artifactVersion": "3.0.0-alpha10",
"description": "An image loading library for Android and Compose Multiplatform.",
- "name": "coil-network-ktor2",
+ "name": "coil-network-ktor3",
"licenses": [
"Apache-2.0"
]

Run ./gradlew :tasks-app-android:exportLibraryDefinitions -PaboutLibraries.exportPath=src/main/assets and commit resulting diff to fix the issue.

@github-actions
Copy link
Contributor

©️ Stale credits for :tasks-app-desktop

diff --git a/tasks-app-desktop/src/main/resources/licenses_desktop.json b/tasks-app-desktop/src/main/resources/licenses_desktop.json
index 274cae3..3e9466b 100644
--- a/tasks-app-desktop/src/main/resources/licenses_desktop.json
+++ b/tasks-app-desktop/src/main/resources/licenses_desktop.json
@@ -325,7 +325,7 @@
]
},
{
- "uniqueId": "io.coil-kt.coil3:coil-network-ktor2-jvm",
+ "uniqueId": "io.coil-kt.coil3:coil-network-ktor3-jvm",
"developers": [
{
"name": "Coil Contributors"
@@ -333,7 +333,7 @@
],
"artifactVersion": "3.0.0-alpha10",
"description": "An image loading library for Android and Compose Multiplatform.",
- "name": "coil-network-ktor2",
+ "name": "coil-network-ktor3",
"licenses": [
"Apache-2.0"
]

Run ./gradlew :tasks-app-desktop:exportLibraryDefinitions -PaboutLibraries.exportPath=src/main/resources and commit resulting diff to fix the issue.

@github-actions
Copy link
Contributor

©️ Stale credits for :tasks-app-android

diff --git a/tasks-app-android/src/main/assets/licenses_android.json b/tasks-app-android/src/main/assets/licenses_android.json
index f5fb798..1559ebc 100644
--- a/tasks-app-android/src/main/assets/licenses_android.json
+++ b/tasks-app-android/src/main/assets/licenses_android.json
@@ -1877,7 +1877,7 @@
]
},
{
- "uniqueId": "io.coil-kt.coil3:coil-network-ktor2-android",
+ "uniqueId": "io.coil-kt.coil3:coil-network-ktor3-android",
"developers": [
{
"name": "Coil Contributors"
@@ -1885,7 +1885,7 @@
],
"artifactVersion": "3.0.0-alpha10",
"description": "An image loading library for Android and Compose Multiplatform.",
- "name": "coil-network-ktor2",
+ "name": "coil-network-ktor3",
"licenses": [
"Apache-2.0"
]

Run ./gradlew :tasks-app-android:exportLibraryDefinitions -PaboutLibraries.exportPath=src/main/assets and commit resulting diff to fix the issue.

@github-actions
Copy link
Contributor

©️ Stale credits for :tasks-app-desktop

diff --git a/tasks-app-desktop/src/main/resources/licenses_desktop.json b/tasks-app-desktop/src/main/resources/licenses_desktop.json
index 31e7172..3e9466b 100644
--- a/tasks-app-desktop/src/main/resources/licenses_desktop.json
+++ b/tasks-app-desktop/src/main/resources/licenses_desktop.json
@@ -325,7 +325,7 @@
]
},
{
- "uniqueId": "io.coil-kt.coil3:coil-network-ktor2-jvm",
+ "uniqueId": "io.coil-kt.coil3:coil-network-ktor3-jvm",
"developers": [
{
"name": "Coil Contributors"

Run ./gradlew :tasks-app-desktop:exportLibraryDefinitions -PaboutLibraries.exportPath=src/main/resources and commit resulting diff to fix the issue.

@opatry opatry merged commit f13a3e0 into main Oct 11, 2024
@opatry opatry deleted the fix-coil3-ktor3 branch October 11, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants