Skip to content

Fix crash at user fetch due to not robust error logging #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
opatry merged 1 commit into from
Jun 16, 2025
Merged

Fix crash at user fetch due to not robust error logging #263

opatry merged 1 commit into from
Jun 16, 2025

Conversation

@opatry
Copy link
Owner

@opatry opatry commented Jun 16, 2025

Description

  • Simplify user info fetch error logging (no doc to allow robust check)
  • No relying on ResponseException and its status code to customize logging (still not easy to make reliable and also hard to unit test, no way to mock ResponseException properly).

Checklist

  • I have read the CONTRIBUTING guide
  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing

@opatry opatry linked an issue Jun 16, 2025 that may be closed by this pull request
Crash when fetching user info at launch #262
Closed
@opatry opatry merged commit 176b215 into main Jun 16, 2025
7 checks passed
@opatry opatry deleted the fix-crash-at-user-info-fetch branch June 16, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash when fetching user info at launch

2 participants

@opatry