Skip to content

Handle all errors from Google Tasks API globally #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
opatry merged 4 commits into from
May 28, 2025
Merged

Handle all errors from Google Tasks API globally #245

opatry merged 4 commits into from
May 28, 2025

Conversation

@opatry
Copy link
Owner

@opatry opatry commented May 27, 2025 •
edited
Loading

Description

  • Using a Ktor HttpResponseValidator with expectSuccess=true
  • Use expectSuccess in *GoogleAuthenticator impls
  • Add logger to UserViewModel and log UserInfoErrorResponse data

Checklist

  • I have read the CONTRIBUTING guide
  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing

@opatry opatry force-pushed the gtasks-error-as-dedicated-exception branch 2 times, most recently from 60d6b2b to 0212da3 Compare May 28, 2025 06:07
Repository owner deleted a comment from github-actions bot May 28, 2025
Repository owner deleted a comment from github-actions bot May 28, 2025
Repository owner deleted a comment from github-actions bot May 28, 2025
Repository owner deleted a comment from github-actions bot May 28, 2025
@opatry opatry force-pushed the gtasks-error-as-dedicated-exception branch from 094997c to 6263ab6 Compare May 28, 2025 17:23
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2025

Job Summary for Gradle

Build & Test :: unit-tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
Taskfolio test :tasks-app-android:testStoreReleaseUnitTest jvmTest 8.12.1 ❌ Build Scan not published

@opatry opatry force-pushed the gtasks-error-as-dedicated-exception branch from 6263ab6 to 6142eef Compare May 28, 2025 18:07
@opatry opatry merged commit 3db89c8 into main May 28, 2025
7 checks passed
@opatry opatry deleted the gtasks-error-as-dedicated-exception branch May 28, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@opatry