Skip to content

Test TaskListsViewModel #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
opatry merged 5 commits into from
May 8, 2025
Merged

Test TaskListsViewModel #117

opatry merged 5 commits into from
May 8, 2025

Conversation

@opatry
Copy link
Owner

@opatry opatry commented May 8, 2025 •
edited
Loading

Description

  • Handle error with a simple logger for now (see Notify user about error #115 for a step further)
  • Review API contract to only expose ID instead of UI model
  • Remove unused/unsuitable last update date of TaskListUiModel
  • Add unit tests covering simple actions
  • Add basic unit test to cover repository data flow update (see Unit test DataModel to UIModel mappers #116 for simpler version)

Checklist

  • I have read the CONTRIBUTING guide
  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

Job Summary for Gradle

Build & Test :: build
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
Taskfolio :tasks-app-desktop:assemble 8.12.1 ✅ Build Scan not published
Taskfolio :tasks-app-android:assembleStoreRelease 8.12.1 ❌ Build Scan not published
Taskfolio :tasks-app-android:exportLibraryDefinitions 8.12.1 ✅ Build Scan not published
Taskfolio :tasks-app-desktop:exportLibraryDefinitions 8.12.1 ✅ Build Scan not published

opatry added 2 commits May 8, 2025 14:14
@opatry
Remove unused TaskListUiModel.lastUpdate
1aab36b 
There was no UI need and the format as `Instant.toString()` was weird and barely usable at UI level.
If needed at some point, depending on need (sorting, display, …), choose the proper format and convert from data model's `Instant`.
@opatry
Add TaskListsViewModelTest
f9bf3a8
@opatry opatry force-pushed the test-tasklistsviewmodel branch from af22b36 to e84386b Compare May 8, 2025 12:14
@opatry opatry force-pushed the test-tasklistsviewmodel branch from e84386b to 65cdb2e Compare May 8, 2025 12:22
@opatry opatry merged commit aa4642d into main May 8, 2025
1 check passed
@opatry opatry deleted the test-tasklistsviewmodel branch May 8, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@opatry