Skip to content

Conversation

@opatry
Copy link
Owner

@opatry opatry commented Apr 28, 2025

Description

Since Compose UI 1.8.0-rc01, it appears material icons aren't transitively made available (which is good).
Had to replace the unique Material icon being used in About by a locally defined vector icon (same asset at the end of the day, fetch from Compose Icons > Icons > Material Symbols > Check Circle).
Other icons were already Lucide icons brought by Compose Icons > Icons > Lucide.

Checklist

  • I have read the CONTRIBUTING guide
  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing

@github-actions
Copy link
Contributor

©️ Stale credits for :tasks-app-desktop

diff --git a/tasks-app-desktop/src/main/resources/licenses_desktop.json b/tasks-app-desktop/src/main/resources/licenses_desktop.json
index 29a126c..84e7603 100644
--- a/tasks-app-desktop/src/main/resources/licenses_desktop.json
+++ b/tasks-app-desktop/src/main/resources/licenses_desktop.json
@@ -181,6 +181,20 @@
"Apache-2.0"
]
},
+ {
+ "uniqueId": "com.mikepenz:aboutlibraries-core",
+ "developers": [
+ {
+ "name": "Mike Penz"
+ }
+ ],
+ "artifactVersion": "12.1.0-rc04",
+ "description": "AboutLibraries automatically detects all dependencies of a project and collects their information including the license. Optionally visualising it via the provided ui components.",
+ "name": "AboutLibraries Core Library",
+ "licenses": [
+ "Apache-2.0"
+ ]
+ },
{
"uniqueId": "com.squareup.okio:okio",
"developers": [
@@ -1215,6 +1229,20 @@
"Apache-2.0"
]
},
+ {
+ "uniqueId": "org.jetbrains.kotlinx:kotlinx-collections-immutable",
+ "developers": [
+ {
+ "name": "JetBrains Team"
+ }
+ ],
+ "artifactVersion": "0.3.8",
+ "description": "Kotlin Immutable Collections multiplatform library",
+ "name": "kotlinx-collections-immutable",
+ "licenses": [
+ "Apache-2.0"
+ ]
+ },
{
"uniqueId": "org.jetbrains.kotlinx:kotlinx-coroutines-core",
"developers": [

Run ./gradlew :tasks-app-desktop:exportLibraryDefinitions and commit resulting diff to fix the issue.

@github-actions
Copy link
Contributor

©️ Stale credits for :tasks-app-android

diff --git a/tasks-app-android/src/main/assets/licenses_android.json b/tasks-app-android/src/main/assets/licenses_android.json
index f0c5153..92a4823 100644
--- a/tasks-app-android/src/main/assets/licenses_android.json
+++ b/tasks-app-android/src/main/assets/licenses_android.json
@@ -1732,6 +1732,20 @@
"Apache-2.0"
]
},
+ {
+ "uniqueId": "com.mikepenz:aboutlibraries-core",
+ "developers": [
+ {
+ "name": "Mike Penz"
+ }
+ ],
+ "artifactVersion": "12.1.0-rc04",
+ "description": "AboutLibraries automatically detects all dependencies of a project and collects their information including the license. Optionally visualising it via the provided ui components.",
+ "name": "AboutLibraries Core Library",
+ "licenses": [
+ "Apache-2.0"
+ ]
+ },
{
"uniqueId": "com.squareup.okio:okio",
"developers": [
@@ -2654,6 +2668,20 @@
"Apache-2.0"
]
},
+ {
+ "uniqueId": "org.jetbrains.kotlinx:kotlinx-collections-immutable",
+ "developers": [
+ {
+ "name": "JetBrains Team"
+ }
+ ],
+ "artifactVersion": "0.3.8",
+ "description": "Kotlin Immutable Collections multiplatform library",
+ "name": "kotlinx-collections-immutable",
+ "licenses": [
+ "Apache-2.0"
+ ]
+ },
{
"uniqueId": "org.jetbrains.kotlinx:kotlinx-coroutines-android",
"developers": [

Run ./gradlew :tasks-app-android:exportLibraryDefinitions and commit resulting diff to fix the issue.

@opatry opatry force-pushed the update-compose-ui branch from ce846af to 5ff6bca Compare April 28, 2025 18:00
@opatry opatry merged commit e9b60cf into main Apr 28, 2025
2 checks passed
@opatry opatry deleted the update-compose-ui branch April 28, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants