Skip to content

[IE11] Fixed support check for Event.constructor #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2016
Merged

[IE11] Fixed support check for Event.constructor #61

merged 1 commit into from
Dec 19, 2016

Conversation

MichaelSp
Copy link
Contributor

This check works on IE11

@elia
Copy link
Member

elia commented Jun 9, 2016

@meh just as a remainder, this change is necessary since rescue now ignores JS errors (except maybe those inheriting from Error).

@MichaelSp
Copy link
Contributor Author

anything I can do to get this released?

@MichaelSp
Copy link
Contributor Author

ping @meh @elia

@sonicdes sonicdes mentioned this pull request Nov 11, 2016
Closed
@MichaelSp
Copy link
Contributor Author

necessary change not merged since 6 month? Not so necessary?

@elia elia merged commit 6791db2 into opal:master Dec 19, 2016
@elia
Copy link
Member

elia commented Dec 19, 2016

@MichaelSp I was about to suggest to change the PR to rescue JS::Exception instead of using try/catch. But looking again try/catch won't break backwards compatibility.

Please ping me if you submit other PRs like this and I'll try my best to help and get things merged.

@MichaelSp
Copy link
Contributor Author

Thanks elia! I currently have no other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelSp @elia