-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] JSoup upgrade #584
base: master
Are you sure you want to change the base?
[WIP] JSoup upgrade #584
Conversation
different handling of .text() (missing )
Since version 1.11.1, Jsoup replaces " " ( |
different handling of .text() (missing )
The test failures should be fixed now, but more testing of the parts of libopac not covered by the automated tests is required (see above). |
see also #639 for other things broken by the dependency upgrade |
ouch, sorry, somehow missed this. I think I needed to upgrade to replace the (no longer really working) stetho with flipper for debugging. I'll look into this and downgrade or fix, just need to find the time. |
Ah, okay. Regarding Stetho issues: I think a recent Chrome update broke it, also noticed that in https://github.com/johan12345/EVMap. It still works in other Chromium-based browsers though (Microsoft Edge, Brave). These the corresponding Stetho and Chromium issues: facebook/stetho#696, https://bugs.chromium.org/p/chromium/issues/detail?id=1187142 |
I reverted for now |
@TacoTheDank already tried to upgrade JSoup in #581, but this lead to some test failures in libopac. We need to investigate these and also do some testing of search in different OPAC systems to make sure that we don't introduce bugs with the JSoup upgrade.