Broke some windows builds. #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 4, 2015 17:50
Bring back doFmtVerbLevelColor
…ging into zanderz/colors_2015.12.04
Bring back doFmtVerbLevelColor
zanderz
force-pushed
the
zanderz/colors_2015.12.04
branch
from
f94469a to
8512c9f
Compare
…ging into zanderz/colors_2015.12.04
|
@zanderz Did I overlook something that you fixed in this change which my changes did do? I think it makes sense to keep the implementations separate but will try to unify the code later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke some builds for people using go-logging; this should fix that. Also brings back doFmtVerbLevelColor, which we can now support.
I was wondering, though, whether the ansi color translator belongs in here? not sure anyone would want it.
@maxtaco