Skip to content

revert Error() api change #88

Closed
Closed
@coryb

Description

@coryb

In commit 0758a84 Error changed from
Error(format string, args ...interface{})
to
Error(args ...interface{})

So now all of Error calls in my projects print the literal formats. I am seeing stuff like:

err := fmt.Errorf("Error Message")
log.Error("Thing failed: %s", err)

now prints the format literally like:

Thing failed: %sError Message

I would say that the Error api should be no different than the other log level statements Critical, Warning, Notice, Info, Debug.

So I kindly ask you to revert the Error api change made in 0758a84.

Thanks!
-Cory

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions