This repository was archived by the owner on Feb 21, 2025. It is now read-only.
feat(protocol): Brotli Compression #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚
|
refcell
added
A-protocol
refcell
commented
Jan 8, 2025
Comment on lines
123
to
129
| fn write(&mut self, data: &[u8]) -> CompressorResult<usize> { | ||
| if self.closed { | ||
| return Err(CompressorError::Brotli); | ||
| } | ||
|
|
||
| // First append the new data to the raw buffer. | ||
| self.raw.extend_from_slice(data); | ||
|
|
||
| // Compress the raw buffer. | ||
| self.compressed = | ||
| compress_brotli(&self.raw, self.level).map_err(|_| CompressorError::Brotli)?; | ||
|
|
||
| Ok(data.len()) | ||
| let written = self.writer.write(data).map_err(|_| CompressorError::Brotli)?; | ||
| Ok(written) | ||
| } |
There was a problem hiding this comment.
This is broken and it's not clear to me why.
|
Closing since this is tracked in #176. This PR can be used as a reference. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates brotli compression to use the lib.
Replaces alloy-rs/op-alloy#305