Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): Block building task #1258

Merged
merged 4 commits into from
Mar 17, 2025
Merged

feat(engine): Block building task #1258

merged 4 commits into from
Mar 17, 2025

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Mar 13, 2025

Overview

Adds a new task to the EngineTasks that builds a new block with engine_forkchoiceUpdate and then imports it with engine_newPayload. As a side effect, it updates the local heads after the payload imports successfully.

@clabby clabby added K-feature Kind: feature A-node Area: node crates labels Mar 13, 2025
@clabby clabby self-assigned this Mar 13, 2025
@clabby clabby force-pushed the cl/block-build-task branch from 8f3c971 to 223dc6c Compare March 13, 2025 00:47
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.5%. Comparing base (2c9fa5e) to head (bc61cb8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/node/rpc/src/attributes.rs 0.0% 6 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clabby clabby force-pushed the cl/eng-task-queue branch from 499740d to e4c0ff2 Compare March 13, 2025 04:10
@clabby clabby force-pushed the cl/block-build-task branch 3 times, most recently from aa3fe9e to 4c0c291 Compare March 13, 2025 05:36
@clabby clabby force-pushed the cl/block-build-task branch from 4c0c291 to c1e5515 Compare March 13, 2025 06:08
@clabby clabby marked this pull request as ready for review March 17, 2025 02:11
@clabby clabby requested review from refcell and emhane as code owners March 17, 2025 02:11
Base automatically changed from cl/eng-task-queue to main March 17, 2025 13:50
@refcell refcell enabled auto-merge March 17, 2025 13:59
@refcell refcell added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit c1941af Mar 17, 2025
19 of 20 checks passed
@refcell refcell deleted the cl/block-build-task branch March 17, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-node Area: node crates K-feature Kind: feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants