Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): Synchronous task queue #1256

Merged
merged 2 commits into from
Mar 17, 2025
Merged

feat(engine): Synchronous task queue #1256

merged 2 commits into from
Mar 17, 2025

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Mar 13, 2025

Overview

Note

WIP, fleshing out with the actor + block building task in child branches

Refactors the engine tasks into a new format that can be processed by a synchronous task queue. In this model, engine tasks are considered atomic over the EngineState, guaranteeing tasks have exclusive access of the local engine state during execution.

Higher up, the engine actor will use this queue to synchronously execute engine events in-order, and can serve the other actors asynchronous copies of the EngineState rather than sharing it with a lock.

@clabby clabby added K-feature Kind: feature A-node Area: node crates labels Mar 13, 2025
@clabby clabby self-assigned this Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 92.0%. Comparing base (ebfe85f) to head (e4c0ff2).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/protocol/protocol/src/block.rs 0.0% 34 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clabby clabby force-pushed the cl/eng-task-queue branch from 499740d to e4c0ff2 Compare March 13, 2025 04:10
@clabby clabby marked this pull request as ready for review March 17, 2025 02:11
@clabby clabby requested review from refcell and emhane as code owners March 17, 2025 02:11
@refcell refcell merged commit 2c9fa5e into main Mar 17, 2025
19 of 20 checks passed
@refcell refcell deleted the cl/eng-task-queue branch March 17, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-node Area: node crates K-feature Kind: feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants