feat: support customization metric auto scaling #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add defualt kms with additional override kms * fix: typo * chore: update policy suffix * chore: test cloudwatch log with kms * chore: aws parameter confusion * chore: update var naming * fix: count depends on undetermined resource * chore: ignore count on data source * chore : turn var back to default null * chore: test * chore: test * chore: test * chore: test * chore: test * chore: update variable name * chore: test new update from tf aws prov. * fix: fix provider version to 4.65 dua to bug of 4.66 * chore: remove 4.66 feature * chore: test <= sign
…:oozou/terraform-aws-ecs-fargate-service into feat/support-multiple-sidecard-container
bemillenium
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request 🚀
Thank you for help us contribute! Please give us more information about this PR.
What 😗
Added
local.is_created_aws_appautoscaling_targetlocal.is_target_tracking_scalinglocal.is_contain_predefined_metricaws_appautoscaling_policy.target_tracking_scaling_policies,aws_appautoscaling_policy.step_scaling_policies,module.step_alarmstep_scaling_configuration,target_tracking_configurationChanged
aws_secretsmanager_secret.thisaws_appautoscaling_target.this,aws_appautoscaling_policy.target_tracking_scaling_policies,aws_appautoscaling_policy.step_scaling_policiesRemoved
scaling_configurationWhy 🥺