Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: optimized deregistration delay time #26

Merged
merged 2 commits into from
Sep 22, 2022
Merged

feature: optimized deregistration delay time #26

merged 2 commits into from
Sep 22, 2022

Conversation

xshot9011
Copy link
Contributor

Submit a pull request 🚀

Thank you for help us contribute! Please give us more information about this PR.

What 😗

Added

  • Add variable var.target_group_deregistration_delay to support setting deregistration delay time

Changed

  • Update resource aws_lb_target_group.this to support setting deregistration delay time with attribute deregistration_delay

@xshot9011 xshot9011 requested a review from a team September 21, 2022 16:59
bemillenium
bemillenium approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@bemillenium bemillenium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gooo

@xshot9011 xshot9011 merged commit 3c6b88b into main Sep 22, 2022
@xshot9011 xshot9011 deleted the feature/optimized-deregistration-delay-time branch September 22, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bemillenium bemillenium bemillenium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xshot9011 @bemillenium