Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused var #24

Merged
merged 3 commits into from
Sep 5, 2022
Merged

chore: remove unused var #24

merged 3 commits into from
Sep 5, 2022

Conversation

xshot9011
Copy link
Contributor

@xshot9011 xshot9011 commented Sep 5, 2022 •
edited
Loading

Submit a pull request 🚀

Thank you for help us contribute! Please give us more information about this PR.

What 😗

Changed

  • Update .pre-commit-config.yaml to support --args=--only=terraform_unused_declarations
  • Update CHANGELOG.md to all previous version
  • Fix pre-commit issue

Removed

  • Remove containers_num attribute from variable var.service_info
  • Add description for variables var.ordered_placement_strategy

Why 🥺

  • Remove unused var
  • Update doc

@xshot9011 xshot9011 requested a review from a team September 5, 2022 05:12
@xshot9011 xshot9011 marked this pull request as ready for review September 5, 2022 05:12
@xshot9011 xshot9011 merged commit 39e0f04 into main Sep 5, 2022
@xshot9011 xshot9011 deleted the chore/remove-unused-var branch September 5, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waruwat-dev waruwat-dev waruwat-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xshot9011 @waruwat-dev