Support crumb and cookie to fetching data #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooples
requested changes
Feb 9, 2024
There was a problem hiding this comment.
These are good changes but you would need to add some unit tests for your crumb helper class with at least one positive and negative test case. Negative test case could be to assert that the exception is thrown when crumb is null or empty. Positive case could be to assert that crumb is not null or empty when everything is valid
ooples
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of Yahoo Finance APIs no longer working since missing crumb and cookies. Here is the changes to support crumb parameters and fix unit test failing issues.