feat: add-descriptor webconnectivity urls
#717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdsantos
requested changes
May 12, 2025
| LazyColumn { | ||
| } | ||
|
|
||
| Box( |
There was a problem hiding this comment.
Adding the box to ensure the actions are displayed at the bottom of the screen and not at the end of the URL list.
This ensures we can install the descriptor without having to scroll to the end of the list when its a long one.
| }) | ||
|
|
||
| if (state.selectableItems.size == 1 && selectableItem.item.test == TestType.WebConnectivity) { | ||
| selectableItem.item.inputs.orEmpty().forEach { website -> |
There was a problem hiding this comment.
This needs to be a LazyColumn, since lists can have thousands of links. So ideally TestItems and URLs should be sharing the LazyColumn above-
aanorbel
force-pushed
the
feat/add-descriptor-update
branch
from
af18b0c to
0f35d2a
Compare
sdsantos
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #710