Skip to content

fix: 'Learn more' button doesn't work #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

fix: 'Learn more' button doesn't work #687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions composeApp/src/iosMain/kotlin/org/ooni/probe/SetupDependencies.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,13 +345,20 @@ class SetupDependencies(
}

private fun openUrl(openUrl: PlatformAction.OpenUrl): Boolean {
val url = openUrl.url
return NSURL.URLWithString(url)?.let {
if (UIApplication.sharedApplication.canOpenURL(it)) {
UIApplication.sharedApplication.openURL(it)
val urlString = openUrl.url
return NSURL.URLWithString(urlString)?.let { nsUrlString ->
if (UIApplication.sharedApplication.canOpenURL(nsUrlString)) {
UIApplication.sharedApplication.openURL(url = nsUrlString, options = emptyMap<Any?, Any>(), completionHandler = {
isSuccessfullyOpened ->
if (isSuccessfullyOpened) {
Logger.i { "Successfully opened URL: $urlString" }
} else {
Logger.e { "Failed to open URL: $urlString" }
}
})
return@let true
} else {
Logger.e { "Cannot open URL: $url" }
Logger.e { "Cannot open URL: $urlString" }
return@let false
}
} ?: false
Expand Down
Loading