update iOS screenshots #602
Conversation
iosApp/iosApp/iOSApp.swift
Outdated
| if launchArguments.contains("--skipOnboarding") { | ||
| UserDefaults.standard.set(3, forKey: "notification_popup") | ||
| } |
There was a problem hiding this comment.
I think this should have a comment explaining what is going on.
| import platform.darwin.NSObject | ||
| import platform.darwin.NSObjectMeta | ||
|
|
||
| object PreferenceMigration : DataMigration<Preferences> { |
There was a problem hiding this comment.
This is applied not just for testing right? I feel like this will override our BootstrapPreferences, because it sets FIRST_RUN. Can't we just run this for testing? Through some flag like you have?
There was a problem hiding this comment.
This is not for testing. To ensure that i can bypass onboarding, I needed to find a way to migrate native preferences to multiplatform which we did not do before. One way forward was to roll a preference migration by hand. Applies only to apps that dont have multiplatform preferences already.
There was a problem hiding this comment.
Ok, you confirmed the migration doesn't run for new users? Then it's ok.
2 participants
No description provided.