Skip to content

Fix fastlane locales with symlinks #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Fix fastlane locales with symlinks #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,21 +112,13 @@ platform :android do
desc ""
lane :capture_screens do |options|
organization = organization!(options)
locales = locales_or_default(options)

locales = if options[:locales]
options[:locales].split(',')
else
case organization
when "ooni" then ['ar', 'en-US', 'hi-IN', 'pt-BR', 'sk', 'zh-CN', 'ca', 'es-ES', 'id', 'ro', 'sq', 'zh-TW', 'de-DE', 'fa', 'is-IS', 'ru-RU', 'th', 'el-GR', 'fr-FR', 'it-IT', 'tr-TR']
when "dw" then ['en-US', 'de', 'es', 'fr', 'pt-BR', 'ru', 'tr']
end
end

gradle(task: "clean copyBrandingToCommonResources assembleFullDebug assembleFullDebugAndroidTest -Porganization=#{organization}")
# gradle(task: "clean copyBrandingToCommonResources assembleFullDebug assembleFullDebugAndroidTest -Porganization=#{organization}")

enable_demo_mode
capture_android_screenshots(
app_package_name: package_name(organization),
app_package_name: package_name(organization, debug: true),
locales: locales,
output_directory: metadata_path(organization),
clear_previous_screenshots: false
Expand Down Expand Up @@ -267,9 +259,20 @@ def metadata_path(organization)
end
end

def package_name(organization)
def package_name(organization, debug: false)
case organization
when "ooni" then "org.openobservatory.ooniprobe"
when "dw" then "com.dw.ooniprobe"
end
end + (debug ? '.dev' : '')
end

def locales_or_default(options)
if options[:locales]
options[:locales].split(',')
else
case options[:organization]
when "ooni" then ['ar', 'en-US', 'hi-IN', 'pt-BR', 'sk', 'zh-CN', 'ca', 'es-ES', 'id', 'ro', 'sq', 'zh-TW', 'de-DE', 'fa', 'is-IS', 'ru-RU', 'th', 'el-GR', 'fr-FR', 'it-IT', 'tr-TR']
when "dw" then ['en-US', 'de', 'es', 'fr', 'pt-BR', 'ru', 'tr']
end
end
end
1 change: 1 addition & 0 deletions fastlane/metadata/android/pt-BR
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/Users/sergiosantos/Android/ooni-multiplatform/fastlane/metadata/android/pt-rBR
1 change: 1 addition & 0 deletions fastlane/metadata/android/zh-CN
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/Users/sergiosantos/Android/ooni-multiplatform/fastlane/metadata/android/zh-rCN
1 change: 1 addition & 0 deletions fastlane/metadata/android/zh-TW
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/Users/sergiosantos/Android/ooni-multiplatform/fastlane/metadata/android/zh-rTW
1 change: 1 addition & 0 deletions fastlane/metadata/dw/android/pt-BR
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/Users/sergiosantos/Android/ooni-multiplatform/fastlane/metadata/dw/android/pt-rBR
1 change: 1 addition & 0 deletions fastlane/metadata/dw/ios/pt-BR
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/Users/sergiosantos/Android/ooni-multiplatform/fastlane/metadata/dw/ios/pt-rBR
1 change: 1 addition & 0 deletions fastlane/metadata/ios/pt-BR
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/Users/sergiosantos/Android/ooni-multiplatform/fastlane/metadata/ios/pt-rBR
1 change: 1 addition & 0 deletions fastlane/metadata/ios/zh-CN
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/Users/sergiosantos/Android/ooni-multiplatform/fastlane/metadata/ios/zh-rCN
1 change: 1 addition & 0 deletions fastlane/metadata/ios/zh-TW
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/Users/sergiosantos/Android/ooni-multiplatform/fastlane/metadata/ios/zh-rTW
Loading