feat: split out reusable probe-core - #1506
Draft
aanorbel wants to merge 2 commits into
Draft
Conversation
aanorbel
force-pushed
the
feat/probe-core
branch
from
August 7, 2026 18:18
f544699 to
1c1733c
Compare
aanorbel
marked this pull request as ready for review
August 7, 2026 20:44
aanorbel
marked this pull request as draft
August 7, 2026 20:44
sdsantos
reviewed
Aug 10, 2026
Comment on lines
+44
to
+45
| override val labelResKey: String = "Test_Experimental_Fullname" | ||
| override val iconResKey: String = "test_experimental" |
Contributor
There was a problem hiding this comment.
I feel we're not gaining much from this String keys. We can't use when on them. Why not remove them and just have a regular when on the extension function?
| MAX_RUNTIME_DISABLED | ||
| } | ||
|
|
||
| private fun buildSoftwareName(taskOrigin: TaskOrigin): String { |
Contributor
There was a problem hiding this comment.
Why do we need to repeat this here?
Comment on lines
+32
to
+34
| Unit.KB -> "TestResults_Kbps" | ||
| Unit.MB -> "TestResults_Mbps" | ||
| Unit.GB -> "TestResults_Gbps" |
Contributor
There was a problem hiding this comment.
Not gaining much here too, with this String keys.
Contributor
|
In general it looks good. I feel, with more work, can improve a bit more things. But that's not necessary for a Proof of Concept. I'm thinking of:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.