Skip to content

chore: extract bundle configuration item #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

chore: extract bundle configuration item #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions iosApp/Configuration/Config.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
TEAM_ID=
OONI_TEAM_ID=
OONI_PROBE_BUNDLE_ID=org.ooni.probe
OONI_PROBE_APP_NAME=OONI Probe
NMS_BUNDLE_ID=org.dw.probe
NMS_APP_NAME=News Media Scan
NMS_TEAM_ID=
BUNDLE_ID=org.ooni.probe.OONIProbe
APP_NAME=OONI Probe
32 changes: 16 additions & 16 deletions iosApp/iosApp.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_ASSET_PATHS = "\"iosApp/Preview Content\"";
DEVELOPMENT_TEAM = "${TEAM_ID}";
DEVELOPMENT_TEAM = "${OONI_TEAM_ID}";
ENABLE_PREVIEWS = YES;
FRAMEWORK_SEARCH_PATHS = (
"$(SRCROOT)/../shared/build/xcode-frameworks/$(CONFIGURATION)/$(SDK_NAME)",
Expand All @@ -648,9 +648,9 @@
"-framework",
composeApp,
);
PRODUCT_BUNDLE_IDENTIFIER = org.ooni.probe.debug;
"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = org.ooni.probe.debug;
PRODUCT_NAME = "${APP_NAME}";
PRODUCT_BUNDLE_IDENTIFIER = "${OONI_PROBE_BUNDLE_ID}.debug";
"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = "${OONI_PROBE_BUNDLE_ID}.debug";
PRODUCT_NAME = "${OONI_PROBE_APP_NAME}";
PROVISIONING_PROFILE_SPECIFIER = "";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
Expand All @@ -666,7 +666,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_ASSET_PATHS = "\"iosApp/Preview Content\"";
DEVELOPMENT_TEAM = "${TEAM_ID}";
DEVELOPMENT_TEAM = "${OONI_TEAM_ID}";
ENABLE_PREVIEWS = YES;
FRAMEWORK_SEARCH_PATHS = (
"$(SRCROOT)/../shared/build/xcode-frameworks/$(CONFIGURATION)/$(SDK_NAME)",
Expand All @@ -684,9 +684,9 @@
"-framework",
composeApp,
);
PRODUCT_BUNDLE_IDENTIFIER = org.ooni.probe;
"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = org.ooni.probe;
PRODUCT_NAME = "${APP_NAME}";
PRODUCT_BUNDLE_IDENTIFIER = "${OONI_PROBE_BUNDLE_ID}";
"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = "${OONI_PROBE_BUNDLE_ID}";
PRODUCT_NAME = "${OONI_PROBE_APP_NAME}";
PROVISIONING_PROFILE_SPECIFIER = "";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
Expand All @@ -701,7 +701,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_ASSET_PATHS = "\"iosApp/Preview Content\"";
DEVELOPMENT_TEAM = "${TEAM_ID}";
DEVELOPMENT_TEAM = "${NMS_TEAM_ID}";
ENABLE_PREVIEWS = YES;
FRAMEWORK_SEARCH_PATHS = (
"$(SRCROOT)/../shared/build/xcode-frameworks/$(CONFIGURATION)/$(SDK_NAME)",
Expand All @@ -719,9 +719,9 @@
"-framework",
composeApp,
);
PRODUCT_BUNDLE_IDENTIFIER = org.dw.probe.debug;
"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = org.dw.probe.debug;
PRODUCT_NAME = "$(TARGET_NAME)";
PRODUCT_BUNDLE_IDENTIFIER = "${NMS_BUNDLE_ID}.debug";
"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = "${NMS_BUNDLE_ID}.debug";
PRODUCT_NAME = "${NMS_APP_NAME}";
PROVISIONING_PROFILE_SPECIFIER = "";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
Expand All @@ -736,7 +736,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_ASSET_PATHS = "\"iosApp/Preview Content\"";
DEVELOPMENT_TEAM = "${TEAM_ID}";
DEVELOPMENT_TEAM = "${NMS_TEAM_ID}";
ENABLE_PREVIEWS = YES;
FRAMEWORK_SEARCH_PATHS = (
"$(SRCROOT)/../shared/build/xcode-frameworks/$(CONFIGURATION)/$(SDK_NAME)",
Expand All @@ -754,9 +754,9 @@
"-framework",
composeApp,
);
PRODUCT_BUNDLE_IDENTIFIER = org.dw.probe;
"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = org.dw.probe;
PRODUCT_NAME = "$(TARGET_NAME)";
PRODUCT_BUNDLE_IDENTIFIER = "${NMS_BUNDLE_ID}";
"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = "${NMS_BUNDLE_ID}";
PRODUCT_NAME = "${NMS_APP_NAME}";
PROVISIONING_PROFILE_SPECIFIER = "";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
Expand Down