feat: Configure Sentry crash reporting #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdsantos
force-pushed
the
crash-reporting
branch
from
56a3320 to
e329aa4
Compare
|
Please fix broken test |
aanorbel
reviewed
Oct 2, 2024
|
|
||
| cocoapods { | ||
| ios.deploymentTarget = "12.0" | ||
| ios.deploymentTarget = "15.3" |
There was a problem hiding this comment.
If sentry is the only thing forcing us to jump versions, can we use an older version of sentry?
There was a problem hiding this comment.
This was me during bug fixing. But I just copied the minimum we had on the iOS config files. I think we had a lower minimum here than there, so I just matched it. Our minimum is 15.3 right?
There was a problem hiding this comment.
Oh, then I have to fix it on a bunch of different places.
sdsantos
force-pushed
the
crash-reporting
branch
from
24d9997 to
7b53a64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106