Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address gosec warnings #1648

Merged
merged 1 commit into from
Aug 7, 2024
Merged

chore: address gosec warnings #1648

merged 1 commit into from
Aug 7, 2024

Conversation

DecFox
Copy link
Contributor

@DecFox DecFox commented Aug 7, 2024

Checklist

  • I have read the contribution guidelines
  • reference issue for this pull request: ooniprobe-cli v3.23 release process probe#2783
  • if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request:
  • if you changed code inside an experiment, make sure you bump its version number

Description

This diff addresses gosec warnings and tries to minimise them as much as possible. The gosec warnings for the current master branch can be found here: https://github.com/ooni/probe-cli/actions/runs/10286957901/job/28468879578#step:6:1153.

@DecFox DecFox requested a review from hellais as a code owner August 7, 2024 18:19
@DecFox
Copy link
Contributor Author

DecFox commented Aug 7, 2024

It seems we should be a using a stronger random number generator than the one offered by crypto/rand. This has been documented here as something we should potentially work on in the future.

@DecFox DecFox merged commit 98ab90e into master Aug 7, 2024
15 of 18 checks passed
@DecFox DecFox deleted the chore/gosec branch August 7, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant