feat(openvpn): implement richer input #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ainghazal
force-pushed
the
feat/openvpn-richer-input-2
branch
from
ddecdf3
to
bf6ed4c
Compare
This commit: 1. modifies `./internal/registry` and its `openvpn.go` file such that `openvpn` has its own private target loader; 2. modifies `./internal/experiment/openvpn` to use the richer input targets to merge the options for the openvpn experiment. 3. removes cache from session after fetching openvpn config
the separation of loadRemote by experiment name won't be needed anymore after transitioning to richerinput.
ainghazal
force-pushed
the
feat/openvpn-richer-input-2
branch
2 times, most recently
from
dda649a
to
183c7ab
Compare
bassosimone
suggested changes
Jun 24, 2024
ainghazal
force-pushed
the
feat/openvpn-richer-input-2
branch
from
51388d0
to
12752f3
Compare
bassosimone
added a commit
that referenced
this pull request
Jun 25, 2024
Calling the endpoint base URL (e.g., `https://www.example.com/`) "endpoint" could cause confusion because usually an API endpoint is something like `https://www.example.com/api/v1/check-in`. To obviate this semantic issue, this diff attempts to avoid calling base URLs as endpoint throughout the tree. I am going to account this work as part of ooni/backend#754 because this is one of the possibly issues on which we can account this work. The original conversation with @ainghazal, which prodded me to make these changes, was related to his feedback after implementing #1625.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
modifies
./internal/registryand itsopenvpn.gofile such thatopenvpnhas its own private target loader;modifies
./internal/experiment/openvpnto use the richer input targets to merge the options for the openvpn experiment.removes cache from session after fetching openvpn config
Checklist