Skip to content

Commit

Permalink
chore: update github workflow to remove third party dependency (#788)
Browse files Browse the repository at this point in the history
## Proposed Changes

- Replace `wzieba/Firebase-Distribution-Github-Action` with scripts
managed by the team

## Context

ooni/probe#2643
  • Loading branch information
aanorbel authored Jul 22, 2024
1 parent 1b8924c commit e42dc11
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ jobs:
uses: actions/checkout@v4

- name: Get issue number
uses: actions/github-script@v6
uses: actions/github-script@v7
id: get_issue_number
with:
script: |
Expand Down Expand Up @@ -187,13 +187,14 @@ jobs:
name: OoniDevFullDebugApk

- name: Upload artifact to Firebase App Distribution
uses: wzieba/Firebase-Distribution-Github-Action@v1.7.0
id: uploadArtifact
with:
appId: ${{secrets.FIREBASE_APP_ID}}
serviceCredentialsFileContent: ${{ secrets.CREDENTIAL_FILE_CONTENT }}
groups: testers
file: ooniDevFull/debug/app-ooni-dev-full-debug.apk
- name: Write Summary
env:
INPUT_APPID: ${{secrets.FIREBASE_APP_ID}}
INPUT_SERVICECREDENTIALSFILECONTENT: ${{ secrets.CREDENTIAL_FILE_CONTENT }}
GOOGLE_APPLICATION_CREDENTIALS: service_credentials_content.json
INPUT_GROUPS: testers
INPUT_FILE: ooniDevFull/debug/app-ooni-dev-full-debug.apk
run: |
echo "View this release in the Firebase console: ${{ steps.uploadArtifact.outputs.FIREBASE_CONSOLE_URI }}" >> $GITHUB_STEP_SUMMARY
cat <<< "${INPUT_SERVICECREDENTIALSFILECONTENT}" > service_credentials_content.json
sudo npm install -g firebase-tools
firebase appdistribution:distribute "$INPUT_FILE" --app "$INPUT_APPID" --groups "$INPUT_GROUPS" --testers "$INPUT_TESTERS" --release-notes "$(git log -1 --pretty=short)"

0 comments on commit e42dc11

Please sign in to comment.