Fix: Updated Broadcast receiver to do nothing if key is null (#648)

ooni · Dec 18, 2023 · 6508067 · 6508067
1 parent d759f09
commit 6508067
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/app/src/main/java/org/openobservatory/ooniprobe/common/service/RunTestService.java b/app/src/main/java/org/openobservatory/ooniprobe/common/service/RunTestService.java
@@ -209,6 +209,10 @@ public void onReceive(Context context, Intent intent) {
             ) {
                 return;
             }
+            // If key is null, do nothing
+            if (key == null) {
+                return;
+            }
             switch (key) {
                 case TestAsyncTask.RUN:
                     Log.d(TAG, "TestAsyncTask.RUN");

diff --git a/app/src/main/java/org/openobservatory/ooniprobe/receiver/TestRunBroadRequestReceiver.java b/app/src/main/java/org/openobservatory/ooniprobe/receiver/TestRunBroadRequestReceiver.java
@@ -49,6 +49,10 @@ public TestRunBroadRequestReceiver(PreferenceManager preferenceManager, EventLis
     public void onReceive(Context context, Intent intent) {
         String key = intent.getStringExtra("key");
         String value = intent.getStringExtra("value");
+        // If key is null, do nothing
+        if (key == null) {
+            return;
+        }
         switch (key) {
             case TestAsyncTask.START:
                 listener.onStart(service);