add collectors to ooniapi #1032
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDiazN
reviewed
Nov 5, 2025
ooniapi/services/ooniprobe/src/ooniprobe/routers/v1/probe_services.py
Outdated
Show resolved
Hide resolved
aagbsn
force-pushed
the
add_list_collectors_to_ooniapi
branch
from
6242901 to
9af8291
Compare
LDiazN
reviewed
Nov 7, 2025
|
|
||
| @router.post("/collectors", tags=["ooniprobe"]) | ||
| def list_collectors( | ||
| settings: Settings = Depends(get_settings), |
Contributor
There was a problem hiding this comment.
Can we use the SettingsDep type in ooniprobe.dependencies instead?
Example usage:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.