Allow Groups of order > 2^15 in conformance test (Nemocas#1600)

ooinaruhugh · Feb 15, 2024 · 45ee11c · 45ee11c
1 parent 8ed1cb4
commit 45ee11c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/test/Groups-conformance-tests.jl b/test/Groups-conformance-tests.jl
@@ -57,8 +57,13 @@ function test_Group_interface(G::Group)
 
         @testset "order, rand" begin
             if is_finite(G)
-                @test order(Int16, G) isa Int16
-                @test order(BigInt, G) isa BigInt
+                ord = order(BigInt, G)
+                @test ord isa BigInt
+                if ord < typemax(Int16)
+                    @test order(Int16, G) isa Int16
+                else
+                    @test_throws InexactError order(Int16, G)
+                end
                 @test order(G) >= 1
                 @test is_trivial(G) == (order(G) == 1)
             else

diff --git a/test/generic/PermGroupAPI-test.jl b/test/generic/PermGroupAPI-test.jl
@@ -1,7 +1,7 @@
 @testset "GroupsCore API PermGroup" begin
 
     include(joinpath(dirname(dirname(pathof(AbstractAlgebra))), "test", "Groups-conformance-tests.jl"))
-    @testset "Sym($n)" for n in [1,2,5]
+    @testset "Sym($n)" for n in [1,2,5,10]
         G = SymmetricGroup(n)
         test_Group_interface(G)
         test_GroupElem_interface(rand(G, 2)...)