This repository was archived by the owner on Apr 30, 2021. It is now read-only.
Export components #126
Merged
Export components #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By exporting the components, we can take advantage of the powerful tree-shaking feature which will omit the unused parts of code -- making the overall app size even smaller. Also the components are now named, because the `displayName` component property can be inferred from the `const` expression, but not from the `static` class member. (as seen in the changed snapshots :))
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 34 33 -1
=====================================
- Hits 34 33 -1
Continue to review full report at Codecov.
|
Owner
|
Looks good to me. Thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By exporting the components, we can take advantage of the powerful tree-shaking feature which will omit the unused parts of code -- making the overall app size even smaller.
Also the components are now named, because the
displayNamecomponent property can be inferred from theconstexpression, but not from thestaticclass member. (as seen in the changed snapshots :))