Skip to content
This repository was archived by the owner on Jan 6, 2023. It is now read-only.
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

Co-located task scheduler does not respect capacity contrains #880

Open
@RolT

Description

@RolT

Hello,

The :onyx.task-scheduler/colocated scheduler does not respect tasks' :onyx/max-peers constrain. I do not know if there is a reason for that. The code seems to explicitly prevent it: https://github.com/onyx-platform/onyx/blob/0.14.x/src/onyx/scheduling/colocated_task_scheduler.clj#L114-L116

Is it a feature ? If so could we make it an option (I'd be happy to provide a PR) ? I need a version of this scheduler that respects tasks capacity constrains. Is there something wrong in just returning true here instead ? I did a few tests with this modification, simulating multiple peers with docker, and there was no errors.

Any thoughts ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions