Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

fix for webpack 4 and issue with the webpack callback #12

Merged
merged 10 commits into from
Mar 1, 2019

Conversation

koslo
Copy link
Contributor

@koslo koslo commented Feb 6, 2019

for webpack 4 the '.default' isnt needed
for older versions is the call requried

@koslo
Copy link
Contributor Author

koslo commented Feb 7, 2019

Hi.
There is a issue with the webpack callback. It is called for each file. Running in production takes a long time. I think it is doing the other stuff for each file again.
So when you have 10 mjml files and running in dev it takes for example 30s. In production it will take more than 300s...
This is a solution with Promise.all. Easier is with async/await...
Known issue: watch not working on the mjml files.

@koslo koslo changed the title fix for webpack 4 fix for webpack 4 and issue with the webpack callback Feb 7, 2019
@johnvanhulsen johnvanhulsen merged commit 0ce58b1 into onyourmarks-agency:master Mar 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants