Skip to content

fix hint on images.ts #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

luapmartin
Copy link

@luapmartin luapmartin commented May 6, 2025

fix hint on images.ts when running npm run check

src/utils/images.ts:74:13 - warning ts(7043): Variable '_image' implicitly has an 'any' type, but a better type may be inferred from usage.

fix hint on images.ts
@SZim92
Copy link

SZim92 commented May 7, 2025

Hey @luapmartin, nice catch on the type hint! I submitted PR #631 earlier this week for the same issue, using an OptimizedImage type derived from ImagesOptimizer’s return type to keep things aligned if the structure changes.

Appreciate you jumping in, always good to see type safety getting attention!

@luapmartin
Copy link
Author

perfect, thanks @SZim92, that's even better, let me close this one in favour of yours. 🚢

@luapmartin luapmartin closed this May 7, 2025
@luapmartin luapmartin deleted the patch-1 branch May 7, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants