refactor: workflow update and fix

onurkanbakirci · Dec 16, 2023 · 17bb587 · 17bb587
1 parent 69a15c7
commit 17bb587
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 12 deletions.
diff --git a/.github/workflows/composite/publish-lib/action.yml b/.github/workflows/composite/publish-lib/action.yml
@@ -32,10 +32,6 @@ runs:
       shell: "bash"
       run: dotnet pack ${{ inputs.path }} --configuration Release --no-build
 
-    - name: Add github as a source
-      shell: "bash"
-      run: dotnet nuget add source --username onurkanbakirci --password ${{inputs.api_key}} --store-password-in-clear-text --name github ${{inputs.package_source}}}
-
     - name: Publish nuget packages
       shell: "bash"
-      run: dotnet nuget push ${{ inputs.nupkg_path }} --source ${{inputs.source}} --api-key ${{inputs.api_key}}
+      run: dotnet nuget push ${{ inputs.nupkg_path }} -k ${{inputs.api_key}} -s ${{inputs.package_source}}
diff --git a/.github/workflows/integration-core.yml b/.github/workflows/integration-core.yml
@@ -19,7 +19,6 @@ env:
 
   project_path: ./src/Integration.Core/
   nupkg_path: ./src/Integration.Core/bin/Release/Integration.Core.1.0.0.nupkg
-  nupkg_source: 'github'
   nupkg_github_secret: ${{ secrets.GITHUB_TOKEN }}
   nupkg_nuget_secret: ${{ secrets.NUGET_API_KEY }}
   github_registry_url: https://nuget.pkg.github.com/onurkanbakirci/index.json
@@ -74,7 +73,6 @@ jobs:
           package_source: ${{env.github_registry_url}}
           path: ${{ env.project_path }}
           nupkg_path: ${{env.nupkg_path}}
-          source: ${{ env.nupkg_source }}
           api_key: ${{ env.nupkg_github_secret }}
 
   publish_lib_to_nuget:
@@ -92,5 +90,4 @@ jobs:
           package_source: ${{env.nuget_registry_url}}
           path: ${{ env.project_path }}
           nupkg_path: ${{env.nupkg_path}}
-          source: ${{ env.nupkg_source }}
           api_key: ${{ env.nupkg_nuget_secret }}
diff --git a/.github/workflows/trendyol-integration.yml b/.github/workflows/trendyol-integration.yml
@@ -20,7 +20,6 @@ env:
 
   project_path: ./src/Marketplaces/Integration.Marketplaces.Trendyol/
   nupkg_path: ./src/Marketplaces/Integration.Marketplaces.Trendyol/bin/Release/Integration.Marketplaces.Trendyol.1.0.0.nupkg
-  nupkg_source: 'github'
   nupkg_github_secret: ${{ secrets.GITHUB_TOKEN }}
   nupkg_nuget_secret: ${{ secrets.NUGET_API_KEY }}
   github_registry_url: https://nuget.pkg.github.com/onurkanbakirci/index.json
@@ -51,7 +50,7 @@ jobs:
   test_lib:
     name: Test Lib
     runs-on: ubuntu-latest
-    needs: build-lib
+    needs: build_lib
 
     steps:
       - name: Checkout repository
@@ -75,7 +74,6 @@ jobs:
           package_source: ${{env.github_registry_url}}
           path: ${{ env.project_path }}
           nupkg_path: ${{env.nupkg_path}}
-          source: ${{ env.nupkg_source }}
           api_key: ${{ env.nupkg_github_secret }}
 
   publish_lib_to_nuget:
@@ -93,5 +91,4 @@ jobs:
           package_source: ${{env.nuget_registry_url}}
           path: ${{ env.project_path }}
           nupkg_path: ${{env.nupkg_path}}
-          source: ${{ env.nupkg_source }}
           api_key: ${{ env.nupkg_nuget_secret }}