This repository has been archived by the owner on Nov 23, 2022. It is now read-only.
Add a code to customize the key. #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding getIpFromRequest method to get the request's IP (onur-ozkan#84) * upgrade to v3.1.0 Co-authored-by: Oleksandr Bordun <bordun.alexandr@gmail.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.3 to 1.14.9. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.13.3...v1.14.9) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.1...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fj2008
commented
Mar 14, 2022
There was a problem hiding this comment.
I use it as follows.
@RateLimit({ keyPrefix: 'sign-up', keyFactory: (req: Request) => { return 'hello rate-limiter'; }, duration: 60, errorMessage: 'Accounts cannot be created more than once in per minute', }) @Get('/rate/test') public async rateLimiterTest() { return 'hello'; }
Returns the result value of the keyFactory function.
The key value can be modified by the developer through the return value.
|
Thank you for the PR!. It looks very useful, but I wonder if this works also for Fastify. Since we don't have the 'express' dependency in this project why you imported it here? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the library well.
But I wanted the developer to set the key value.
I try it on the company project and pull request it because it's good.
I look forward to your kind cooperation.
If possible, please review the code... Thanks you!!