Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic! on errors; fix apparent bug in JSON value handling #3

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Don't panic! on errors; fix apparent bug in JSON value handling #3

merged 2 commits into from
Jun 1, 2023

Conversation

lmcmicu
Copy link
Contributor

@lmcmicu lmcmicu commented May 24, 2023

Closes #2

@lmcmicu lmcmicu self-assigned this May 24, 2023
ckindermann
ckindermann approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@ckindermann ckindermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! (Though I still maintain that the conversion from different data types to String is not a bug fix but a feature addition supporting some syntactic sugar for hiccup.)

@jamesaoverton jamesaoverton merged commit fb8bfe0 into main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesaoverton jamesaoverton jamesaoverton approved these changes

@ckindermann ckindermann ckindermann approved these changes

Assignees

@lmcmicu lmcmicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't panic!
3 participants
@lmcmicu @jamesaoverton @ckindermann