Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit post-process merging in custommap schemas #626

Merged
merged 19 commits into from
Aug 7, 2023
Merged

Permit post-process merging in custommap schemas #626

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
55cce57
Fixes #350 - Permit post-process merging in custommap schemas
zhibek Jul 14, 2023
f7bf5ec
Fix sonar failures
zhibek Jul 14, 2023
5e7473e
Initial test coverage
zhibek Jul 14, 2023
8bdcc76
Increase test coverage
zhibek Jul 14, 2023
9d84810
Remove redundant logging. Declare merge variables as doubles not ints.
zhibek Jul 14, 2023
42c9b5b
Test ConfiguredProfile.postProcessLayerFeatures()
zhibek Jul 15, 2023
79eacad
Fix test code formatting
zhibek Jul 15, 2023
2485c42
Re-run CI
zhibek Jul 15, 2023
d9e51c1
Re-run CI (doc link down previously)
zhibek Jul 15, 2023
70f356b
Merge branch 'main' into custommap-postprocess-merging
zhibek Jul 19, 2023
aa79a3f
Rename "merge_overlapping_polygons" to "merge_polygons"
zhibek Jul 19, 2023
ae39870
Avoid implicit attribute name in JsonProperty for MergeLineStrings
zhibek Jul 19, 2023
36cfe4d
Rename "post_process" to "tile_post_process"
zhibek Jul 19, 2023
22b260a
Move postProcessLayerFeatures() processing to constructor
zhibek Jul 19, 2023
f3f9319
Use assertNull() in test
zhibek Jul 19, 2023
9c3f8c2
Reference "tile_post_process" in JSON schema and README
zhibek Aug 5, 2023
0c33d6d
Fix lint for README
zhibek Aug 5, 2023
d236bd9
Allow lines and polygons to be merged sequentially
zhibek Aug 5, 2023
a708ac2
Update example custom schema
zhibek Aug 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename "post_process" to "tile_post_process"
  • Loading branch information
@zhibek
zhibek committed Jul 19, 2023
commit 36cfe4d5444c1896783812123e36aa26361812ff
2 changes: 1 addition & 1 deletion ...ustommap/src/main/java/com/onthegomap/planetiler/custommap/configschema/FeatureLayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
public record FeatureLayer(
String id,
Collection<FeatureItem> features,
@JsonProperty("post_process") PostProcess postProcess
@JsonProperty("tile_post_process") PostProcess postProcess
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good! Only thing left is to mention these features in planetiler.schema.json and planetiler-custommap/README.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change pushed.

) {}
2 changes: 1 addition & 1 deletion planetiler-custommap/src/main/resources/samples/railways.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ layers:
- usage: main
exclude_when:
service: __any__
post_process:
tile_post_process:
merge_line_strings:
min_length: 1
tolerance: 5
Expand Down
8 changes: 4 additions & 4 deletions ...er-custommap/src/test/java/com/onthegomap/planetiler/custommap/ConfiguredFeatureTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ void testFeaturePostProcessorMergeLineStrings() throws GeometryException {
features:
- source: osm
geometry: point
post_process:
tile_post_process:
merge_line_strings:
min_length: 1
tolerance: 5
Expand Down Expand Up @@ -231,7 +231,7 @@ void testFeaturePostProcessorMergePolygons() throws GeometryException {
features:
- source: osm
geometry: point
post_process:
tile_post_process:
merge_polygons:
min_area: 3
""";
Expand Down Expand Up @@ -1169,7 +1169,7 @@ void testSchemaPostProcessWithMergeLineStrings() {
features:
- source: osm
geometry: point
post_process:
tile_post_process:
merge_line_strings:
min_length: 1
tolerance: 5
Expand Down Expand Up @@ -1199,7 +1199,7 @@ void testSchemaPostProcessWithMergePolygons() {
features:
- source: osm
geometry: point
post_process:
tile_post_process:
merge_polygons:
min_area: 3
""";
Expand Down
2 changes: 1 addition & 1 deletion planetiler-custommap/src/test/resources/invalidSchema/invalid_post_process.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ layers:
attributes:
- key: water
- value: wet
post_process:
tile_post_process:
merge_everything:
min_length: 1